Hi,

On um-switcher.php few issues should be corrected :

function insert_into_database
line 326 : $product=array(); -> should be $product_id = array();

There’s a notice about the ‘site_name’=>$sitename
line 376 : $sitename = um_get_option(‘mail_from’);

Thanks,
William

Hi, Mike,
Mmm, it’s embarassing.

There’s a lot of errors inside this file : email_template_setting.php

When You save :
Error: [Table ‘xxxx.images’ doesn’t exist]
SHOW FULL COLUMNS FROM images
Notice: Undefined index: checkboxemail in /www/wp-content/plugins/um-switcher/email_template_setting.php on line 24
Notice: Undefined index: image in /www/wp-content/plugins/um-switcher/email_template_setting.php on line 34
Notice: Undefined index: size in /www/wp-content/plugins/um-switcher/email_template_setting.php on line 42
Notice: Undefined index: tmp_name in /www/wp-content/plugins/um-switcher/email_template_setting.php on line 50

This One :
$wpdb->insert( ‘images’, array( ‘image_url’ => $image_url ), array( ‘%s’ ) );

‘images’ ??? where’s the $wpdb->prefix ???
There’ll be no image insert in the database. It should be :
$wpdb->insert( $table_woo, array( ‘header_image’ => $image_url ), array( ‘%s’ ) );

And this BIG ONE line 27 :
if($checkboxemail == ‘yes’){
$checkboxemail = “yes”;
}else{
$checkboxemail = “no”;
}

You’re joking ??? Non-sense code !!! If value is yes so it’s yes else it’s no… ???

Another thing: in um-switcher.php, you change the status of an order :
$order->update_status( ‘completed’ );
Why ?? I really can’t understand, cause the function is called from the hook ‘woocommerce_thankyou’, so it’s called after a successful purchase you don’t need to change the order status here. It’s a issue when you want to test and pay by chek.

Sorry to write this here, but I must let you remember than I paid 35$ on envato to buy a serious plugin. It does the work I want, and I already said it’s great plugin, but I can’t accept this kind of error.

It’s sad cause it’s well thought out.

I engage you to look on the files of your plugin and please, correct the bugs.

Thanks for your support,
William

• This reply was modified 7 years, 9 months ago by winsiders.

Hi Mike,
At this moment, I code a plugin for a website who uses your plugin.
Yes, I can test it, cause it’s in progress, so i can rewind to the ancient version if something turn bad. And the fact it’s already online and not on localhost it’s an opportunity.
Note, I haven’t add the cron job yet.
Yes, send me a link to dl/ it.
Thx again

Hi Mike,
I haven’t received your mail :/

Hi, Mike,
Sorry to reply only now, I’m coding a lot for a website these days.
I dl/ your files this morning and look at them quickly.

I saw a mistake in um-switcher.php line 382
if(isset($days)){
$days = $loop[‘days’]+$UmWoTD_days;
}else{
$days=0;
}
if(isset($hours)){
$hours = $loop[‘hours’]+$UmWoTD_hours;
}else{
$hours=0;
}
if(isset($mins)){
$mins = $loop[‘mins’]+$UmWoTD_mins;
}else{
$mins=0;
}
/* this section below need to be removed */
$days = $loop[‘days’]+$UmWoTD_days;
$hours = $loop[‘hours’]+$UmWoTD_hours;
$mins = $loop[‘mins’]+$UmWoTD_mins;
/* — end remove —– */

If I see something else, i’ll tell you.

Regards,
William

and this :

function my_media_lib_uploader_enqueue() {
wp_enqueue_media();
wp_register_script( ‘media-lib-uploader-js’, plugins_url( ‘media-lib-uploader.js’ , __FILE__ ), array(‘jquery’) );
wp_enqueue_script( ‘media-lib-uploader-js’ );
}
add_action(‘admin_enqueue_scripts’, ‘my_media_lib_uploader_enqueue’);

You call a file who doesn’t exists… So an error in WP

I paste this here cause I simply meet an error in back office.

<input id=”post-search-input” name=”s” value=”<?php echo $_GET[‘s’]; ?>” type=”search”>

If the ‘s’ isn’t set : notice php. Cause you need to put $_GET[‘s’] in a variable and test it or isset($_GET[‘s’])

Hello winsiders,

I have correct the code. Thank you for your suggestion.